Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbdFVIq0 (ORCPT ); Thu, 22 Jun 2017 04:46:26 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:32862 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbdFVIqY (ORCPT ); Thu, 22 Jun 2017 04:46:24 -0400 Date: Thu, 22 Jun 2017 10:46:19 +0200 From: Daniel Vetter To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexey Brodkin , Daniel Vetter , Carlos Palminha , Dave Airlie , Laurent Pinchart , Neil Armstrong Subject: Re: [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback Message-ID: <20170622084619.buquchxit5aggv6b@phenom.ffwll.local> Mail-Followup-To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexey Brodkin , Carlos Palminha , Dave Airlie , Laurent Pinchart , Neil Armstrong References: <6b270b74-a18d-53ff-81b7-649c7c9411a7@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b270b74-a18d-53ff-81b7-649c7c9411a7@synopsys.com> X-Operating-System: Linux phenom 4.9.0-2-amd64 User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 38 On Wed, Jun 21, 2017 at 10:38:43AM +0100, Jose Abreu wrote: > Hi Daniel, Alexey, > > > On 25-05-2017 15:19, Jose Abreu wrote: > > Now that we have a callback to check if crtc supports a given mode > > we can use it in arcpgu so that we restrict the number of probbed > > modes to the ones we can actually display. > > > > This is specially useful because arcpgu crtc is responsible to set > > a clock value in the commit() stage but unfortunatelly this clock > > does not support all the needed ranges. > > > > Also, remove the atomic_check() callback as mode_valid() callback > > will be called before. > > > > Signed-off-by: Jose Abreu > > Reviewed-by: Alexey Brodkin > > @Daniel: I know that arcpgu is not under drm-misc but could you > apply this into drm-misc-next? Alexey (the arcpgu maintainer) > already gave the reviewed-by and this is also "Reviewed-by: Neil > Armstrong ". It was also tested-by: me. > > @Alexey: Is this ok for you? > > I need this because I have a pending patch for accepting clock > variations instead of always failing when clk_round_rate() does > not return the expected rate. Alexey reviewed it already, and Dave acked it for merging through drm-misc, so applied. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch