Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752831AbdFVJoO (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Jun 2017 05:44:14 -0400
Received: from foss.arm.com ([217.140.101.70]:35338 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751163AbdFVJoM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Jun 2017 05:44:12 -0400
Date: Thu, 22 Jun 2017 10:44:08 +0100
From: Juri Lelli <juri.lelli@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org,
        Catalin Marinas <catalin.marinas@arm.com>, linux@arm.linux.org.uk,
        Will Deacon <will.deacon@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>, arnd.bergmann@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/5] arch_topology: Get rid of "cap_parsing_done"
Message-ID: <20170622094408.puyfkjglvqtlkq3f@e106622-lin>
References: <cover.1498019799.git.viresh.kumar@linaro.org>
 <3cb2fa07035f9333eeaaee3eab37d090777abb99.1498019799.git.viresh.kumar@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3cb2fa07035f9333eeaaee3eab37d090777abb99.1498019799.git.viresh.kumar@linaro.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1377
Lines: 44

Hi,

On 21/06/17 10:16, Viresh Kumar wrote:
> We can reuse "cap_parsing_failed" instead of keeping an additional
> variable here.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/base/arch_topology.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index d1c33a85059e..8239a6232808 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -161,7 +161,6 @@ int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu)
>  
>  #ifdef CONFIG_CPU_FREQ
>  static cpumask_var_t cpus_to_visit;
> -static bool cap_parsing_done;
>  static void parsing_done_workfn(struct work_struct *work);
>  static DECLARE_WORK(parsing_done_work, parsing_done_workfn);
>  
> @@ -173,7 +172,7 @@ init_cpu_capacity_callback(struct notifier_block *nb,
>  	struct cpufreq_policy *policy = data;
>  	int cpu;
>  
> -	if (cap_parsing_failed || cap_parsing_done)
> +	if (cap_parsing_failed)
>  		return 0;
>  
>  	switch (val) {
> @@ -193,7 +192,7 @@ init_cpu_capacity_callback(struct notifier_block *nb,
>  			topology_normalize_cpu_scale();
>  			kfree(raw_capacity);
>  			pr_debug("cpu_capacity: parsing done\n");
> -			cap_parsing_done = true;
> +			cap_parsing_failed = true;

But we didn't actually failed here, right?

Thanks,

- Juri