Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753086AbdFVKQm (ORCPT ); Thu, 22 Jun 2017 06:16:42 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:34652 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbdFVKQk (ORCPT ); Thu, 22 Jun 2017 06:16:40 -0400 MIME-Version: 1.0 In-Reply-To: <20170620013130.GI4493@codeaurora.org> References: <20170618015855.27738-1-chunyan.zhang@spreadtrum.com> <20170618015855.27738-4-chunyan.zhang@spreadtrum.com> <20170620013130.GI4493@codeaurora.org> From: Chunyan Zhang Date: Thu, 22 Jun 2017 18:16:39 +0800 Message-ID: Subject: Re: [PATCH V1 3/9] clk: sprd: add gate clock support To: Stephen Boyd Cc: Chunyan Zhang , Michael Turquette , Rob Herring , Mark Rutland , linux-clk@vger.kernel.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Mark Brown , Xiaolong Zhang , Orson Zhai , Geng Ren , Ben Li Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 51 On 20 June 2017 at 09:31, Stephen Boyd wrote: > On 06/18, Chunyan Zhang wrote: >> diff --git a/drivers/clk/sprd/Makefile b/drivers/clk/sprd/Makefile >> index 8f802b2..333e2b2 100644 >> --- a/drivers/clk/sprd/Makefile >> +++ b/drivers/clk/sprd/Makefile >> @@ -1,3 +1,3 @@ >> ifneq ($(CONFIG_OF),) >> -obj-y += ccu_common.o >> +obj-y += ccu_common.o ccu_gate.o > > Can this be built as a module? Since most of all Spreadtrum device drivers would depend on if clocks have been initialized, so we'd prefer to build this into the kernel image. > >> endif >> diff --git a/drivers/clk/sprd/ccu_gate.c b/drivers/clk/sprd/ccu_gate.c >> new file mode 100644 >> index 0000000..3d27615 >> --- /dev/null >> +++ b/drivers/clk/sprd/ccu_gate.c >> @@ -0,0 +1,102 @@ >> +/* >> + * Spreadtrum gate clock driver >> + * >> + * Copyright (C) 2017 Spreadtrum, Inc. >> + * >> + * SPDX-License-Identifier: GPL-2.0 >> + */ >> + >> +#include >> + >> +#include "ccu_gate.h" >> + >> +DEFINE_SPINLOCK(gate_lock); > > This variable name is not very unique for debugging lockdep > reports. Probably needs 'sprd' in the name. Ok. Thank you for your comments, Chunyan > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project