DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D2C147F40D
Subject: Re: [PATCH 2/2] x86/idle: use dynamic halt poll
To: root <yang.zhang.wz@gmail.com>, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com
Cc: x86@kernel.org, corbet@lwn.net, tony.luck@intel.com, bp@alien8.de,
        peterz@infradead.org, mchehab@kernel.org, akpm@linux-foundation.org,
        krzk@kernel.org, jpoimboe@redhat.com, luto@kernel.org,
        borntraeger@de.ibm.com, thgarnie@google.com, rgerst@gmail.com,
        minipli@googlemail.com, douly.fnst@cn.fujitsu.com, nicstange@gmail.com,
        fweisbec@gmail.com, dvlasenk@redhat.com, bristot@redhat.com,
        yamada.masahiro@socionext.com, mika.westerberg@linux.intel.com,
        yu.c.chen@intel.com, aaron.lu@intel.com, rostedt@goodmis.org,
        me@kylehuey.com, len.brown@intel.com, prarit@redhat.com,
        hidehiro.kawai.ez@hitachi.com, fengtiantian@huawei.com,
        pmladek@suse.com, jeyu@redhat.com, Larry.Finger@lwfinger.net,
        zijun_hu@htc.com, luisbg@osg.samsung.com, johannes.berg@intel.com,
        niklas.soderlund+renesas@ragnatech.se, zlpnobody@gmail.com,
        adobriyan@gmail.com, fgao@48lvckh6395k16k5.yundunddos.com,
        ebiederm@xmission.com, subashab@codeaurora.org, arnd@arndb.de,
        matt@codeblueprint.co.uk, mgorman@techsingularity.net,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-edac@vger.kernel.org, kvm@vger.kernel.org
References: <1498130534-26568-1-git-send-email-root@ip-172-31-39-62.us-west-2.compute.internal>
 <1498130534-26568-3-git-send-email-root@ip-172-31-39-62.us-west-2.compute.internal>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <4444ffc8-9e7b-5bd2-20da-af422fe834cc@redhat.com>
Date: Thu, 22 Jun 2017 13:51:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <1498130534-26568-3-git-send-email-root@ip-172-31-39-62.us-west-2.compute.internal>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1035
Lines: 29


On 22/06/2017 13:22, root wrote:
>  ==============================================================
>  
> +poll_grow: (X86 only)
> +
> +This parameter is multiplied in the grow_poll_ns() to increase the poll time.
> +By default, the values is 2.
> +
> +==============================================================
> +poll_shrink: (X86 only)
> +
> +This parameter is divided in the shrink_poll_ns() to reduce the poll time.
> +By default, the values is 2.

Even before starting the debate on whether this is a good idea or a bad
idea, KVM reduces the polling value to the minimum (10 us) by default
when polling fails.  Also, it shouldn't be bound to
CONFIG_HYPERVISOR_GUEST, since there's nothing specific to virtual
machines here.

Regarding the good/bad idea part, KVM's polling is made much more
acceptable by single_task_running().  At least you need to integrate it
with paravirtualization.  If the VM is scheduled out, you shrink the
polling period.  There is already vcpu_is_preempted for this, it is used
by mutexes.

Paolo