Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbdFVMA7 (ORCPT ); Thu, 22 Jun 2017 08:00:59 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7927 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbdFVMA4 (ORCPT ); Thu, 22 Jun 2017 08:00:56 -0400 Subject: Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs To: Arnd Bergmann References: <20170616065119.10704-1-butao@hisilicon.com> <20170616065119.10704-3-butao@hisilicon.com> <0f79aeea-53e3-6bea-ffa6-0e057f2ff83b@huawei.com> CC: Rob Herring , Mark Rutland , "Wei Xu" , Catalin Marinas , "Will Deacon" , Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" , Kevin Hilman , "Gregory CLEMENT" , Thomas Petazzoni , Masahiro Yamada , Riku Voipio , Thierry Reding , Krzysztof Kozlowski , Eric Anholt , , "Linux Kernel Mailing List" , Linux ARM , , "Guodong Xu" , , From: Bu Tao Message-ID: <24438c4d-21c8-6302-acd4-4f0e223232ce@huawei.com> Date: Thu, 22 Jun 2017 19:58:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.142.51.208] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.594BB112.00D1,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d4e4fa26e960525e98266967d01be01b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2352 Lines: 56 在 2017/6/22 19:51, Arnd Bergmann 写道: > On Thu, Jun 22, 2017 at 1:44 PM, Bu Tao wrote: >> 在 2017/6/17 5:51, Arnd Bergmann 写道: >>> On Fri, Jun 16, 2017 at 8:51 AM, Bu Tao wrote: >>>> +Optional properties for board device: >>>> +- ufs-hi3660-use-rate-B : specifies UFS rate-B >>>> +- ufs-hi3660-broken-fastauto : specifies no fastauto >>>> +- ufs-hi3660-use-HS-GEAR3 : specifies UFS HS-GEAR3 >>>> +- ufs-hi3660-use-HS-GEAR2 : specifies UFS HS-GEAR2 >>>> +- ufs-hi3660-use-HS-GEAR1 : specifies UFS HS-GEAR1 >>>> +- ufs-hi3660-broken-clk-gate-bypass : specifies no clk-gate >>>> +- ufs-hi3660-use-one-line : specifies UFS use one line work >>>> +- reset-gpio : specifies to reset devices >>> >>> >>> Some of these sound rather generic and might apply to UFS implementations >>> other than hi3660, so I'd suggest adding them to the base ufs binding with >>> a generic name instead. >>> >>> Any DT properties that might be useful across multiple implementations >>> should be parsed in generic code that gets called by the individual >>> drivers, >>> and then the properties that are specific to the integration work done by >>> hisilicon should be prefixed with "hisilicon,", but not normally with the >>> SoC name: it is quite possible that another SoC will be derived from this >>> chip and it should reuse the properties. >> >> >> I do not know wheher other SoC need to use the optional properties as >> abover. So here the name of the optional properties has "hi3660". > > They should not have "hi3660" in their names either way, independent > of where they are used. Oh, change the "hi3660" to "hisilicon"? e.g. ufs-hi3660-use-rate-B --> ufs-hisilicon-use-rate-B > >>> (note: this is different from the value of the "compatible" property that >>> is meant to be as specific as possible". >>> >>> Also, please clarify how your binding relates to the ufshcd binding >>> in Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt: does >>> hi3660 implement any registers that are shared with ufshcd, or does >>> it use the same physical interface with a different register set? >> >> No, only show how to use the dt-binding for hi3660 SoC > > My question was about the hardware: does hi3660 implement ufshcd > or not? YES > > Arnd >