Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752467AbdFVMXF (ORCPT ); Thu, 22 Jun 2017 08:23:05 -0400 Received: from smtprelay0080.hostedemail.com ([216.40.44.80]:54144 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750812AbdFVMXE (ORCPT ); Thu, 22 Jun 2017 08:23:04 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:967:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3834:3867:3872:3873:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6117:6119:8599:8603:9025:9388:10004:10049:10400:10848:11027:11232:11658:11914:12043:12048:12555:12682:12740:12760:12776:12895:13069:13311:13357:13439:14107:14181:14659:14849:21080:21433:21627:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: lock31_1a6eb8cc4b442 X-Filterd-Recvd-Size: 1452 Message-ID: <1498134180.24295.2.camel@perches.com> Subject: Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens From: Joe Perches To: Arvind Yadav , idryomov@gmail.com, sage@redhat.com, elder@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 22 Jun 2017 05:23:00 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 544 Lines: 14 On Thu, 2017-06-22 at 17:34 +0530, Arvind Yadav wrote: > File size before: > text data bss dec hex filename > 43100 2161 64 45325 b10d drivers/block/rbd.o > > File size After adding 'const': > text data bss dec hex filename > 43292 1969 64 45325 b10d drivers/block/rbd.o If you are going to do these conversions, I still think it'd be better to use a standard struct declaration. >From 2011, (const was also added) http://lkml.iu.edu/hypermail/linux/kernel/1104.2/00738.html