Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753254AbdFVMrH (ORCPT ); Thu, 22 Jun 2017 08:47:07 -0400 Received: from foss.arm.com ([217.140.101.70]:37752 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753211AbdFVMrF (ORCPT ); Thu, 22 Jun 2017 08:47:05 -0400 Subject: Re: [PATCH v5 1/7] dma: Take into account dma_pfn_offset To: Christoph Hellwig References: <1495621472-9323-1-git-send-email-vladimir.murzin@arm.com> <1495621472-9323-2-git-send-email-vladimir.murzin@arm.com> <20170620132400.GB11370@infradead.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, sza@esh.hu, arnd@arndb.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, alexandre.torgue@st.com, robin.murphy@arm.com, benjamin.gaignard@linaro.org, kbuild-all@01.org, Joerg Roedel , Christian Borntraeger From: Vladimir Murzin Message-ID: <593f90fe-f7e1-a86c-5376-8ed775c65592@arm.com> Date: Thu, 22 Jun 2017 13:47:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170620132400.GB11370@infradead.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 318 Lines: 14 On 20/06/17 14:24, Christoph Hellwig wrote: >> - sg_dma_address(sg) = (dma_addr_t)virt_to_phys(va); >> + sg_dma_address(sg) = (dma_addr_t)(virt_to_phys(va) - PFN_PHYS(dev->dma_pfn_offset)); > > Needs a line break instead of the overly long line. Will do. > > Otherwise this looks fine to me. > Thanks Vladimir