Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753251AbdFVM7n (ORCPT ); Thu, 22 Jun 2017 08:59:43 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:56822 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbdFVM7m (ORCPT ); Thu, 22 Jun 2017 08:59:42 -0400 Message-ID: <1498136291.2655.24.camel@decadent.org.uk> Subject: Re: [PATCH] mm: larger stack guard gap, between vmas From: Ben Hutchings To: Willy Tarreau Cc: Hugh Dickins , Linus Torvalds , Oleg Nesterov , Michal Hocko , "Jason A. Donenfeld" , Rik van Riel , Larry Woodman , "Kirill A. Shutemov" , Tony Luck , "James E.J. Bottomley" , Helge Diller , James Hogan , Laura Abbott , Greg KH , security@kernel.org, linux-distros@vs.openwall.org, qsa@qualys.com, stable , LKML Date: Thu, 22 Jun 2017 13:58:11 +0100 In-Reply-To: <20170622124659.GE22510@1wt.eu> References: <20170622123045.GA2694@decadent.org.uk> <20170622124659.GE22510@1wt.eu> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hZl58V/X4tZA7jTsgnYD" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 94.119.64.9 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2223 Lines: 52 --=-hZl58V/X4tZA7jTsgnYD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > Here's my attempt at a backport to 3.2.=C2=A0=C2=A0This is only tested = on > > x86_64 and I think I should introduce local variables for > > vma_start_gap() in a few places.=C2=A0=C2=A0I had to cherry-pick commit > > 09884964335e "mm: do not grow the stack vma just because of an overrun > > on preceding vma" before this one (which was a clean cherry-pick). >=20 > Ben, I can't apply it on top of 3.2.89 + the patch above, do you have > any other patch in your local branch ? For example the patch tries to > modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one > I'm having here ends at line 159. Sorry, yes, I did this on top of the Debian 3.2 branch and that *does* have a patch to arch/arm/mm/mmap.c that I had forgotten about (commit 7dbaa466780a "ARM: 7169/1: topdown mmap support"). I think you can just drop the changes in ARM's arch_get_unmapped_area_topdown(). Ben. --=20 Ben Hutchings Sturgeon's Law: Ninety percent of everything is crap. --=-hZl58V/X4tZA7jTsgnYD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAllLvuMACgkQ57/I7JWG EQlt/A/8D8Sb202JosLizsFRw2wlmLhylM+Q0YtLKzAlqop2MU+WNZz7ukKISpJy 8SRoQ0FycJceq/3Z/l3/W5RIzHChYQN7fqs/6WXNidpAFKPt/h2I9w7vGqQ7OPTi gV41qR+SPZvOOKT1iLaEoxX4BCtlP+6oA109ZvxXLuuulLYzlUrXM0WpE223BXGK H133kiln2umVCezTNPXsDkU8bhcl+cGkbd1WsMDcjUMixV/1e55XLxCJna68zycx ETTuJTQz/zPqjW+GmcijfKAjb96qnd5b+lpKEcHrLBJ5JKjKo0wktyyh77GADDbG iz9hRNU7owMsmHnvteyQGHKm9pLzOQgL60MPJD5sPArDo22t2izib5HIZWA6uZws mU1kruD4yxzBrUMkQkGPvMka37TboeYb/ResQ04/XgkIsxdboln4X9ZtwXAH48+s Yes6N44tZ5pDMJiTsQO+3v+h9Vfw+xrOjXyg3oKs+UHkY4spRrPW9by3HdPIEHJd U19OBZtmZqcPQIXXw4vVWUnoLAI+PFeMgm9RL/cyFXG+DtINI9xDIn6j+jgJe96A RCuY0El6jxo/6jpJpF16unYMGWVDPyAgCKrKCtNUgpgRhfEFWjyLnSfWwXvfiW/P Zmql/IHNNUIxFq+xfQDD19PeTAQVKp2CEC5zVZJW7mD3HzzR9UA= =Z3xg -----END PGP SIGNATURE----- --=-hZl58V/X4tZA7jTsgnYD--