Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbdFVNOt (ORCPT ); Thu, 22 Jun 2017 09:14:49 -0400 Received: from mail-ot0-f171.google.com ([74.125.82.171]:33907 "EHLO mail-ot0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbdFVNOr (ORCPT ); Thu, 22 Jun 2017 09:14:47 -0400 MIME-Version: 1.0 In-Reply-To: <20170621220943.104170-1-arnd@arndb.de> References: <20170621220943.104170-1-arnd@arndb.de> From: Daniel Drake Date: Thu, 22 Jun 2017 07:14:46 -0600 Message-ID: Subject: Re: [PATCH] ASoC: es8316: add I2C dependency To: Arnd Bergmann Cc: Mark Brown , David Yang , Liam Girdwood , alsa-devel@alsa-project.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 36 On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann wrote: > Without CONFIG_I2C, we get a build failure: > > sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror] > sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] > sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror] > sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable] > > This adds the required Kconfig dependency. > > Fixes: b8b88b70875a ("ASoC: add es8316 codec driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Daniel Drake Thanks for the patch. > --- > sound/soc/codecs/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > index c6286e5ba511..f0f794186186 100644 > --- a/sound/soc/codecs/Kconfig > +++ b/sound/soc/codecs/Kconfig > @@ -546,6 +546,7 @@ config SND_SOC_ES7134 > > config SND_SOC_ES8316 > tristate "Everest Semi ES8316 CODEC" > + depends on I2C > > config SND_SOC_ES8328 > tristate > -- > 2.9.0 >