Message-ID: <1498147673.24295.6.camel@perches.com>
Subject: Re: [PATCH 01/14] staging: fsl-mc: drop macros with possible side
 effects
From: Joe Perches <joe@perches.com>
To: laurentiu.tudor@nxp.com, gregkh@linuxfoundation.org,
        stuyoder@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        marc.zyngier@arm.com, agraf@suse.de, arnd@arndb.de,
        ioana.ciornei@nxp.com, ruxandra.radulescu@nxp.com,
        bharat.bhushan@nxp.com, catalin.horghidan@nxp.com, leoyang.li@nxp.com,
        roy.pledge@nxp.com, linux-arm-kernel@lists.infradead.org
Date: Thu, 22 Jun 2017 09:07:53 -0700
In-Reply-To: <20170622133600.31694-2-laurentiu.tudor@nxp.com>
References: <20170622133600.31694-1-laurentiu.tudor@nxp.com>
         <20170622133600.31694-2-laurentiu.tudor@nxp.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 34

On Thu, 2017-06-22 at 16:35 +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> 
> Several macros were triggering this checkpatch.pl warning:
>   "Macro argument reuse '$arg' - possible side-effects?"
> Fix the warning by turning them into real functions.

good idea and

> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
[]
> +static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
> +				struct dprc_obj_desc *obj_desc)
> +{
> +	return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
> +		mc_dev->obj_desc.id == obj_desc->id;
> +}

I'd reverse the test order and do the strcmp after the comparison

	return?mc_dev->obj_desc.id == obj_desc->id &&
	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);

[]

> +static bool __must_check fsl_mc_is_allocatable(const char *obj_type)
> +{
> +	return strcmp(obj_type, "dpbp") == 0 ||
> +	       strcmp(obj_type, "dpmcp") == 0 ||
> +	       strcmp(obj_type, "dpcon") == 0;
> +}

please be consistent in using either == 0 or !
when using strcmp