Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbdFVQoQ (ORCPT ); Thu, 22 Jun 2017 12:44:16 -0400 Received: from foss.arm.com ([217.140.101.70]:41370 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbdFVQoP (ORCPT ); Thu, 22 Jun 2017 12:44:15 -0400 Date: Thu, 22 Jun 2017 17:44:10 +0100 From: Juri Lelli To: Viresh Kumar Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux@arm.linux.org.uk, Will Deacon , Vincent Guittot , arnd.bergmann@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/5] arch_topology: Get rid of "cap_parsing_done" Message-ID: <20170622164410.brenzszdgweucshj@e106622-lin> References: <3cb2fa07035f9333eeaaee3eab37d090777abb99.1498019799.git.viresh.kumar@linaro.org> <20170622094408.puyfkjglvqtlkq3f@e106622-lin> <20170622142925.GD6314@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622142925.GD6314@vireshk-i7> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1808 Lines: 49 On 22/06/17 19:59, Viresh Kumar wrote: > On 22-06-17, 10:44, Juri Lelli wrote: > > Hi, > > > > On 21/06/17 10:16, Viresh Kumar wrote: > > > We can reuse "cap_parsing_failed" instead of keeping an additional > > > variable here. > > > > > > Signed-off-by: Viresh Kumar > > > --- > > > drivers/base/arch_topology.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > > index d1c33a85059e..8239a6232808 100644 > > > --- a/drivers/base/arch_topology.c > > > +++ b/drivers/base/arch_topology.c > > > @@ -161,7 +161,6 @@ int __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) > > > > > > #ifdef CONFIG_CPU_FREQ > > > static cpumask_var_t cpus_to_visit; > > > -static bool cap_parsing_done; > > > static void parsing_done_workfn(struct work_struct *work); > > > static DECLARE_WORK(parsing_done_work, parsing_done_workfn); > > > > > > @@ -173,7 +172,7 @@ init_cpu_capacity_callback(struct notifier_block *nb, > > > struct cpufreq_policy *policy = data; > > > int cpu; > > > > > > - if (cap_parsing_failed || cap_parsing_done) > > > + if (cap_parsing_failed) > > > return 0; > > > > > > switch (val) { > > > @@ -193,7 +192,7 @@ init_cpu_capacity_callback(struct notifier_block *nb, > > > topology_normalize_cpu_scale(); > > > kfree(raw_capacity); > > > pr_debug("cpu_capacity: parsing done\n"); > > > - cap_parsing_done = true; > > > + cap_parsing_failed = true; > > > > But we didn't actually failed here, right? > > Yeah. So I can actually move this patch to the end of the series and > cap_parsing_done can be dropped then as we will end up using > !raw_capacity instead. And the end result will stay the same. > OK.