Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdFVQxf (ORCPT ); Thu, 22 Jun 2017 12:53:35 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:36688 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753356AbdFVQxc (ORCPT ); Thu, 22 Jun 2017 12:53:32 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Kees Cook Date: Thu, 22 Jun 2017 09:53:30 -0700 X-Google-Sender-Auth: 8x0RYY_b9-5Zp1NVFe2xSGKjaHk Message-ID: Subject: Re: seccomp ptrace selftest failures with 4.4-stable [Was: Re: LTS testing with latest kselftests - some failures] To: Sumit Semwal Cc: Andy Lutomirski , Brian Norris , "Luis R. Rodriguez" , Greg Kroah-Hartman , LKML , "# 3.4.x" , linux-kselftest@vger.kernel.org, Shuah Khan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 32 On Thu, Jun 22, 2017 at 9:18 AM, Sumit Semwal wrote: > Hi Kees, Andy, > > On 15 June 2017 at 23:26, Sumit Semwal wrote: >> 3. 'seccomp ptrace hole closure' patches got added in 4.7 [3] - >> feature and test together. >> - This one also seems like a security hole being closed, and the >> 'feature' could be a candidate for stable backports, but Arnd tried >> that, and it was quite non-trivial. So perhaps we'll need some help >> from the subsystem developers here. > > Could you please help us sort this out? Our goal is to help Greg with > testing stable kernels, and currently the seccomp tests fail due to > missing feature (seccomp ptrace hole closure) getting tested via > latest kselftest. > > If you feel the feature isn't a stable candidate, then could you > please help make the test degrade gracefully in its absence? I don't really want to have that change be a backport -- it's quite invasive across multiple architectures. I would say just add a kernel version check to the test. This is probably not the only selftest that will need such things. :) I'd be happy to review such changes! -Kees -- Kees Cook Pixel Security