Date: Thu, 22 Jun 2017 19:17:49 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Hoan Tran <hotran@apm.com>
Cc: Will Deacon <will.deacon@arm.com>, Jonathan Corbet <corbet@lwn.net>,
        Tai Nguyen <ttnguyen@apm.com>, linux-arm-kernel@lists.infradead.org,
        lkml <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org,
        Loc Ho <lho@apm.com>
Subject: Re: [PATCH v3 3/3] perf: xgene: Add support for SoC PMU version 3
Message-ID: <20170622181749.GF25967@leverpostej>
References: <1496772146-11084-1-git-send-email-hotran@apm.com>
 <1496772146-11084-4-git-send-email-hotran@apm.com>
 <20170622175255.GD25967@leverpostej>
 <CAFHUOYz_WpYa9BhCnQ+ze5-mbM4pWSn84j_EyH0E16ZbAs43tQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFHUOYz_WpYa9BhCnQ+ze5-mbM4pWSn84j_EyH0E16ZbAs43tQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1234
Lines: 32

On Thu, Jun 22, 2017 at 11:13:08AM -0700, Hoan Tran wrote:
> On Thu, Jun 22, 2017 at 10:52 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Tue, Jun 06, 2017 at 11:02:26AM -0700, Hoan Tran wrote:
> > >  static inline void
> > > +xgene_pmu_write_counter64(struct xgene_pmu_dev *pmu_dev, int idx, u64 val)
> > > +{
> > > +     u32 cnt_lo, cnt_hi;
> > > +
> > > +     cnt_hi = upper_32_bits(val);
> > > +     cnt_lo = lower_32_bits(val);
> > > +
> > > +     /* v3 has 64-bit counter registers composed by 2 32-bit registers */
> > > +     xgene_pmu_write_counter32(pmu_dev, 2 * idx, cnt_lo);
> > > +     xgene_pmu_write_counter32(pmu_dev, 2 * idx + 1, cnt_hi);
> > > +}
> >
> > For this to be atomic, we need to disable the counters for the duration
> > of the IRQ handler, which we don't do today.
> >
> > Regardless, we should do that to ensure that groups are self-consistent.
> >
> > i.e. in xgene_pmu_isr() we should call ops->stop_counters() just after
> > taking the pmu lock, and we should call ops->start_counters() just
> > before releasing it.
> 
> Thanks for your comments. I'll fix them and send another version of
> patch set soon.

No need; I'm picking these up now, and I'll apply the fixups locally.

Thanks,
Mark.