Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753634AbdFVTYO (ORCPT ); Thu, 22 Jun 2017 15:24:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:36677 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbdFVTYM (ORCPT ); Thu, 22 Jun 2017 15:24:12 -0400 Subject: Re: [PATCH v2 2/2] x86/xen/efi: Init only efi struct members used by Xen To: Daniel Kiper , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, stable@vger.kernel.org, xen-devel@lists.xenproject.org References: <1498128697-12943-1-git-send-email-daniel.kiper@oracle.com> <1498128697-12943-3-git-send-email-daniel.kiper@oracle.com> Cc: jgross@suse.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, matt@codeblueprint.co.uk, ard.biesheuvel@linaro.org, andrew.cooper3@citrix.com From: Boris Ostrovsky Message-ID: <54b02bd1-b3a7-9154-f007-32bf4c27f553@oracle.com> Date: Thu, 22 Jun 2017 15:25:28 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1498128697-12943-3-git-send-email-daniel.kiper@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 12 On 06/22/2017 06:51 AM, Daniel Kiper wrote: > Current approach, wholesale efi struct initialization from efi_xen, is not > good. Usually if new member is defined then it is properly initialized in > drivers/firmware/efi/efi.c but not in arch/x86/xen/efi.c. As I saw it happened > a few times until now. So, let's initialize only efi struct members used by > Xen to avoid such issues in the future. > > Signed-off-by: Daniel Kiper > Acked-by: Ard Biesheuvel Reviewed-by: Boris Ostrovsky