Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483AbdFVUZO (ORCPT ); Thu, 22 Jun 2017 16:25:14 -0400 Received: from ale.deltatee.com ([207.54.116.67]:54752 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbdFVUZM (ORCPT ); Thu, 22 Jun 2017 16:25:12 -0400 To: Alan Cox References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-4-logang@deltatee.com> <20170622211431.14270378@alans-desktop> Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-ntb@googlegroups.com, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates From: Logan Gunthorpe Message-ID: Date: Thu, 22 Jun 2017 14:24:58 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170622211431.14270378@alans-desktop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: sbates@raithlin.com, gregkh@linuxfoundation.org, arnd@arndb.de, dri-devel@lists.freedesktop.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-alpha@vger.kernel.org, linux-ntb@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 3/7] asm-generic/io.h: make ioread64 and iowrite64 universally available X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 24 On 6/22/2017 2:14 PM, Alan Cox wrote: > If a platform doesn't support 64bit I/O operations from the CPU then you > either need to use some kind of platform/architecture specific interface > if present or accept you don't have one. Yes, I understand that. The thing is that every user that's currently using it right now is patching in their own version that splits it on non-64bit systems. > It's not safe to split it. Possibly for some use cases you could add an > ioread64_maysplit() I'm open to doing something like that. > What btw is the actual ARM compiler warning ? Is the compiler also trying > to tell you it's a bad idea ? It's just the compiler noting that you are mixing volatile and non-volatile pointers. Strangely some io{read|write}XX use volatile but most do not. But it's nothing crazy. Logan