Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbdFVWRK (ORCPT ); Thu, 22 Jun 2017 18:17:10 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:57786 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbdFVWRJ (ORCPT ); Thu, 22 Jun 2017 18:17:09 -0400 Date: Fri, 23 Jun 2017 00:16:36 +0200 (CEST) From: Thomas Gleixner To: Steven Rostedt cc: Marcin Nowakowski , Andrew Morton , "Peter Zijlstra (Intel)" , Thomas Meyer , Ingo Molnar , Daniel Borkmann , Paul Gortmaker , Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH] kernel/extable.c: mark core_kernel_text notrace In-Reply-To: <20170622181050.220c23a3@gandalf.local.home> Message-ID: References: <1498028607-6765-1-git-send-email-marcin.nowakowski@imgtec.com> <20170622181050.220c23a3@gandalf.local.home> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 29 On Thu, 22 Jun 2017, Steven Rostedt wrote: > On Wed, 21 Jun 2017 09:03:26 +0200 > Marcin Nowakowski wrote: > > > > -int core_kernel_text(unsigned long addr) > > +int notrace core_kernel_text(unsigned long addr) > > Is mips the only one with this issue. I hate adding notrace to general > functions if it is only an issue with a single arch. We have unwinders using that function and btw, ftrace has a similar issue with core_kernel_data(). Probably not endless recursive, but not pretty either if you have trace entries from within the tracer itself. > Can we add a: mips_notrace? where we have: > > #ifdef CONFIG_MIPS > # define mips_notrace notrace > #else > # define mips_notrace > #endif We can, but that will explode into an unholy mess sooner than later. I know you'd love to come up with the most convoluted macro magic to make that happen. Thanks, tglx