Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935AbdFVWf6 (ORCPT ); Thu, 22 Jun 2017 18:35:58 -0400 Received: from mga02.intel.com ([134.134.136.20]:14324 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753906AbdFVWf4 (ORCPT ); Thu, 22 Jun 2017 18:35:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,374,1493708400"; d="scan'208";a="1163661185" Date: Fri, 23 Jun 2017 00:35:53 +0200 From: Samuel Ortiz To: "Gustavo A. R. Silva" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference Message-ID: <20170622223553.GH21214@zurbaran.ger.intel.com> References: <20170530204307.GA3931@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170530204307.GA3931@embeddedgus> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 575 Lines: 16 On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote: > NULL checks at line 457: if (!link0 || !link1) {, implies that both > pointers link0 and link1 might be NULL. > Function nfcsim_link_free() dereference pointers link0 and link1. > Add NULL checks before calling nfcsim_link_free() to avoid a > potential NULL pointer dereference. > > Addresses-Coverity-ID: 1364857 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/nfc/nfcsim.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied, thanks. Cheers, Samuel.