Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265057AbTFLXeJ (ORCPT ); Thu, 12 Jun 2003 19:34:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265060AbTFLXeJ (ORCPT ); Thu, 12 Jun 2003 19:34:09 -0400 Received: from x35.xmailserver.org ([208.129.208.51]:9626 "EHLO x35.xmailserver.org") by vger.kernel.org with ESMTP id S265057AbTFLXeG (ORCPT ); Thu, 12 Jun 2003 19:34:06 -0400 X-AuthUser: davidel@xmailserver.org Date: Thu, 12 Jun 2003 16:45:51 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@bigblue.dev.mcafeelabs.com To: Patrick Mochel cc: Robert Love , Greg KH , Andrew Morton , sdake@mvista.com, Linux Kernel Mailing List Subject: Re: [PATCH] udev enhancements to use kernel event queue In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 840 Lines: 31 On Thu, 12 Jun 2003, Patrick Mochel wrote: > > > > + spin_lock(&sequence_lock); > > > + seq = sequence_num++; > > > + spin_unlock(&sequence_lock); > > > + > > > + envp [i++] = scratch; > > > + scratch += sprintf(scratch, "SEQNUM=%ld", seq) + 1; > > > > Nice thinking. It is a shame we need a lock for this, but we don't have > > an atomic_inc_and_return(). > > Those were my sentiments exactly: > > 16:21 * mochel searches for atomic_inc_and_read() :) > > It seems like the following should work. Would someone mind commenting on > it? It does not Pat, look at the generated asm. - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/