Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbdFVX6Q (ORCPT ); Thu, 22 Jun 2017 19:58:16 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:56689 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754010AbdFVX6O (ORCPT ); Thu, 22 Jun 2017 19:58:14 -0400 Date: Thu, 22 Jun 2017 16:58:09 -0700 From: Darren Hart To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Jonathan Woithe , Rafael Wysocki , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes Message-ID: <20170622235809.GB27213@fury> References: <20170616044058.30443-1-kernel@kempniu.pl> <20170616044058.30443-2-kernel@kempniu.pl> <20170621181543.GB25900@fury> <20170621235021.GA32131@marvin.atrad.com.au> <20170622024413.GE25900@fury> <20170622030120.GF32131@marvin.atrad.com.au> <20170622204619.GB4194@kmp-mobile.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170622204619.GB4194@kmp-mobile.hq.kempniu.pl> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 21 On Thu, Jun 22, 2017 at 10:46:19PM +0200, Michał Kępień wrote: > > The events seen by userspace with the original code would be "A-press", > > "B-press", "A-release", "B-release". With the revised code the order of the > > release events would be reversed compared to the previous behaviour. That > > is, unless I've misunderstood how sparse_keymap_report_event() works. > > All you wrote above is correct and this patch does change the order of > release events sent to userspace when multiple hotkeys are pressed > simultaneously. The question is: is it relevant for any practical > scenario? > > Anyway, I find this matter to be of secondary importance. The primary > objective of this patch is to get rid of the kfifo. If anyone has > strong feelings about the change in event ordering, I will be happy to > revert to FIFO in v2. This all looks reasonable to me, I don't see anything requiring a respin. -- Darren Hart VMware Open Source Technology Center