Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbdFWEfU (ORCPT ); Fri, 23 Jun 2017 00:35:20 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34632 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbdFWEfR (ORCPT ); Fri, 23 Jun 2017 00:35:17 -0400 Date: Thu, 22 Jun 2017 21:35:07 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Ben Hutchings cc: Hugh Dickins , Linus Torvalds , Oleg Nesterov , Michal Hocko , "Jason A. Donenfeld" , Rik van Riel , Larry Woodman , "Kirill A. Shutemov" , Tony Luck , "James E.J. Bottomley" , Helge Diller , James Hogan , Laura Abbott , Willy Tarreau , Greg KH , stable , LKML Subject: Re: [PATCH] mm: larger stack guard gap, between vmas In-Reply-To: <20170622123045.GA2694@decadent.org.uk> Message-ID: References: <20170622123045.GA2694@decadent.org.uk> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 901 Lines: 21 On Thu, 22 Jun 2017, Ben Hutchings wrote: > Here's my attempt at a backport to 3.2. This is only tested on > x86_64 and I think I should introduce local variables for > vma_start_gap() in a few places. I had to cherry-pick commit > 09884964335e "mm: do not grow the stack vma just because of an overrun > on preceding vma" before this one (which was a clean cherry-pick). Both your speed and your stamina are much better than mine; and your patch belies your Sturgeon's law signature. I haven't got beyond the architectures yet in my parallel attempt, and you do appear to be doing everything right (but a local variable often welcome, yes). I'm giving up for the night, will contine tomorrow. The only discrepancy I notice so far is that I have arch/alpha/kernel/osf_sys.c arch/ia64/mm/hugetlbpage.c arch/sparc/kernel/sys_sparc_32.c in my list of changed files, but they're not in yours. Hugh