Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754291AbdFWEnW (ORCPT ); Fri, 23 Jun 2017 00:43:22 -0400 Received: from imap.thunk.org ([74.207.234.97]:34802 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754266AbdFWEnV (ORCPT ); Fri, 23 Jun 2017 00:43:21 -0400 Date: Fri, 23 Jun 2017 00:43:14 -0400 From: "Theodore Ts'o" To: Khazhismel Kumykov Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Return EIO on read error in ext4_find_entry Message-ID: <20170623044314.7f23ighkelnpgnah@thunk.org> Mail-Followup-To: Theodore Ts'o , Khazhismel Kumykov , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170622232307.48392-1-khazhy@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170622232307.48392-1-khazhy@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 335 Lines: 10 On Thu, Jun 22, 2017 at 04:23:07PM -0700, Khazhismel Kumykov wrote: > Previously, a read error would be ignored and we would eventually return > NULL from ext4_find_entry, which signals "no such file or directory". We > should be returning EIO. > > Signed-off-by: Khazhismel Kumykov Thanks, applied. - Ted