Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005AbdFWIGT (ORCPT ); Fri, 23 Jun 2017 04:06:19 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:35353 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173AbdFWIGQ (ORCPT ); Fri, 23 Jun 2017 04:06:16 -0400 Subject: Re: [PATCH] kdb: remove unnecessary variable assignment in kdb_bc() To: "Gustavo A. R. Silva" , Jason Wessel Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20170622224123.GA7186@embeddedgus> From: Daniel Thompson Message-ID: <23b97f42-59cd-ffad-9446-0f6ce9595107@linaro.org> Date: Fri, 23 Jun 2017 09:06:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170622224123.GA7186@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 26 On 22/06/17 23:41, Gustavo A. R. Silva wrote: > Value assigned to variable _bp_ at line 415 is the same as at line 434. > This makes such variable assignment unnecessary. > > Addresses-Coverity-ID: 1227025 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Daniel Thompson > --- > kernel/debug/kdb/kdb_bp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c > index 90ff129..039a329e 100644 > --- a/kernel/debug/kdb/kdb_bp.c > +++ b/kernel/debug/kdb/kdb_bp.c > @@ -412,7 +412,6 @@ static int kdb_bc(int argc, const char **argv) > * assume that the breakpoint number is desired. > */ > if (addr < KDB_MAXBPT) { > - bp = &kdb_breakpoints[addr]; > lowbp = highbp = addr; > highbp++; > } else { >