Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754705AbdFWKNu (ORCPT ); Fri, 23 Jun 2017 06:13:50 -0400 Received: from chaos.universe-factory.net ([31.24.148.19]:50268 "EHLO chaos.universe-factory.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694AbdFWKNt (ORCPT ); Fri, 23 Jun 2017 06:13:49 -0400 Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration To: Jiri Benc Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org References: <6e2c8bb77be42834f1da5a3ca79f5e455574a136.1497825555.git.mschiffer@universe-factory.net> <20170623105220.18561f34@griffin> From: Matthias Schiffer Message-ID: <113c3fe1-f490-d92d-2b4a-69b7115d8115@universe-factory.net> Date: Fri, 23 Jun 2017 12:13:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170623105220.18561f34@griffin> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kX56mNhitti5XKHKoPEP4U8CnxwXjNWHG" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3504 Lines: 89 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kX56mNhitti5XKHKoPEP4U8CnxwXjNWHG Content-Type: multipart/mixed; boundary="gdhcD84BvwBeUEEsOuaHekIgx323jI82F"; protected-headers="v1" From: Matthias Schiffer To: Jiri Benc Cc: davem@davemloft.net, hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Message-ID: <113c3fe1-f490-d92d-2b4a-69b7115d8115@universe-factory.net> Subject: Re: [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration References: <6e2c8bb77be42834f1da5a3ca79f5e455574a136.1497825555.git.mschiffer@universe-factory.net> <20170623105220.18561f34@griffin> In-Reply-To: <20170623105220.18561f34@griffin> --gdhcD84BvwBeUEEsOuaHekIgx323jI82F Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 06/23/2017 10:52 AM, Jiri Benc wrote: > This patchset looks good overall (would send my Acked-by for most of > this but I'm late). >=20 > On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote: >> Log messages in these >> functions are removed, as it is generally unexpected to find error out= put >> for netlink requests in the kernel log. Userspace should be able to ha= ndle >> errors based on the error codes returned via netlink just fine. >=20 > However, this is not really true. It's impossible to find out what went= > wrong when you use e.g. iproute2 to configure a vxlan link. >=20 > We really need to convert the kernel log messages to the extended > netlink errors. Since you removed them prematurely, could you please > work on that? >=20 > Thanks, >=20 > Jiri >=20 I was told the extended netlink error facilities were not ready yet, has that changed since the last release? Off the top of my head, I can't think of any other setting I can do with iproute2 that will write its errors in the kernel log; but there are quit= e a lot settings that will just return a very unspecific error code. Isn't = it more common for the userspace tool to handle diagnostics in such cases? Anyways, I will gladly work on improving the error handling if someone ca= n give me a pointer how these extended netlink errors are used. Matthias --gdhcD84BvwBeUEEsOuaHekIgx323jI82F-- --kX56mNhitti5XKHKoPEP4U8CnxwXjNWHG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEZmTnvaa2aYgexS51Fu8/ZMsgHZwFAllM6doACgkQFu8/ZMsg HZxu1RAAxvL/+1JaqpLa1pylNirDsxh10jivbIHLA/aqamrkqrSbfaxoSJGJ0OBN qnu3+8V0x/4fKe0T+zsUX9h59avdD7P1T/b9XZXA2UkqNynaSZTCcMtYr8sAINp3 ERzK65mKxim/V9cA3mw/adFiRLLE7I7sc+bGQzH6vI0LhEL/z5segLlsTJ02k8Gu 6wKFiCrsZEEJV78yuChiKjkpzCMn5qnhG9XEzTythCW894BJVMAm8dbRyIC24Rqo iyFo13IOOcf1XczStP7S91LjT0oTJpxJiyuNRUD+Ioyx5r0jqqiXLYOXqOxlsqlC WXP24emz327BVMbdlBJrTxLH5rqkMY8x67Z/21LoHBslyrUkxGcZGbUXx2IbXn58 R1LuEX+Eqs5ZIgAwLJfd6DkgvO0w6c57qcqon6oYRbxDAOeaNF5wDnxctctczjYk JBTertmvSZkzubbjij+/DV+HQUMljprtnwwJASNX2+e5Q2jDoHGxGJ+rMgQBnoAn 7kf+m10q/5R8+nbYZd5+6vaGU+tJ7BC1VvXWB1ysqLROc0/BIQs5eSg6FRTIkMX9 MYMv3yZu8dC/nzu20nIM2yx56TeDpe/FiVX5gSBxZ1Pe+3a8WN74E15DKibda45r ipHJXIIkK7hIEM5nUJmx9sI1K5PWVhdDsxbLNv/JPGyjW78XHrY= =EqSM -----END PGP SIGNATURE----- --kX56mNhitti5XKHKoPEP4U8CnxwXjNWHG--