Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753805AbdFWLje (ORCPT ); Fri, 23 Jun 2017 07:39:34 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33240 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbdFWLjc (ORCPT ); Fri, 23 Jun 2017 07:39:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <1498202111-30469-1-git-send-email-liangchen.linux@gmail.com> From: Liang Chen Date: Fri, 23 Jun 2017 19:39:30 +0800 Message-ID: Subject: Re: [PATCH] bcache: release the allocated id, not its multiple of BCACHE_MINORS To: tang.junhui@zte.com.cn Cc: bcache@linux.ewheeler.net, colyli@suse.de, linux-bcache@vger.kernel.org, linux-bcache-owner@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v5NBdep7015006 Content-Length: 2513 Lines: 75 Sure! I will find you there:) On Fri, Jun 23, 2017 at 3:28 PM, wrote: > Hello Liang chen: > > Please see this patch: > > http://www.spinics.net/lists/linux-bcache/msg04572.html > > Do you have a wechat account? please add me: tangjunhui1984 > > We can talk more about bcache. > > Thanks. > > > > 发件人: Liang Chen > 收件人: linux-bcache@vger.kernel.org, > 抄送: linux-kernel@vger.kernel.org, colyli@suse.de, > bcache@linux.ewheeler.net, Liang Chen > 日期: 2017/06/23 15:16 > 主题: [PATCH] bcache: release the allocated id, not its multiple of > BCACHE_MINORS > 发件人: linux-bcache-owner@vger.kernel.org > ________________________________ > > > > The id passed to ida_simple_remove has to be the one originally > allocated with ida_simple_get, not the one after multipling by > BCACHE_MINORS. > > Signed-off-by: Liang Chen > --- > drivers/md/bcache/super.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index e57353e..9f64477 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -734,7 +734,8 @@ static void bcache_device_free(struct bcache_device *d) > if (d->disk && d->disk->queue) > blk_cleanup_queue(d->disk->queue); > if (d->disk) { > - ida_simple_remove(&bcache_minor, > d->disk->first_minor); > + ida_simple_remove(&bcache_minor, > + > d->disk->first_minor / BCACHE_MINORS); > put_disk(d->disk); > } > > @@ -784,7 +785,7 @@ static int bcache_device_init(struct bcache_device *d, > unsigned block_size, > > if (!(d->bio_split = bioset_create(4, offsetof(struct bbio, > bio))) || > !(d->disk = alloc_disk(BCACHE_MINORS))) { > - ida_simple_remove(&bcache_minor, minor); > + ida_simple_remove(&bcache_minor, minor / > BCACHE_MINORS); > return -ENOMEM; > } > > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >