Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbdFWNgs (ORCPT ); Fri, 23 Jun 2017 09:36:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25837 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbdFWNgr (ORCPT ); Fri, 23 Jun 2017 09:36:47 -0400 Subject: Re: [PATCH v3 10/11] x86/mm: Enable CR4.PCIDE on supported systems To: Andy Lutomirski , x86@kernel.org Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Linus Torvalds , Andrew Morton , Mel Gorman , "linux-mm@kvack.org" , Nadav Amit , Rik van Riel , Dave Hansen , Arjan van de Ven , Peter Zijlstra , Juergen Gross References: <57c1d18b1c11f9bc9a3bcf8bdee38033415e1a13.1498022414.git.luto@kernel.org> From: Boris Ostrovsky Message-ID: Date: Fri, 23 Jun 2017 09:35:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <57c1d18b1c11f9bc9a3bcf8bdee38033415e1a13.1498022414.git.luto@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 21 > diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c > index f33eef4ebd12..a136aac543c3 100644 > --- a/arch/x86/xen/enlighten_pv.c > +++ b/arch/x86/xen/enlighten_pv.c > @@ -295,6 +295,12 @@ static void __init xen_init_capabilities(void) > setup_clear_cpu_cap(X86_FEATURE_ACC); > setup_clear_cpu_cap(X86_FEATURE_X2APIC); > > + /* > + * Xen PV would need some work to support PCID: CR3 handling as well > + * as xen_flush_tlb_others() would need updating. > + */ > + setup_clear_cpu_cap(X86_FEATURE_PCID); > + > if (!xen_initial_domain()) > setup_clear_cpu_cap(X86_FEATURE_ACPI); > Reviewed-by: Boris Ostrovsky