Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbdFWOqq (ORCPT ); Fri, 23 Jun 2017 10:46:46 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:12215 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754238AbdFWOqn (ORCPT ); Fri, 23 Jun 2017 10:46:43 -0400 From: Philippe CORNU To: Eric Anholt , "dri-devel@lists.freedesktop.org" , Alexandre TORGUE , Yannick FERTRE CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Thread-Topic: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support" Thread-Index: AQHS6+N6GVxSphwPQEmz93WC3PVVP6IyZbYA Date: Fri, 23 Jun 2017 14:46:34 +0000 Message-ID: References: <1497889685-27349-2-git-send-email-philippe.cornu@st.com> <20170622175636.22723-1-eric@anholt.net> <20170622175636.22723-2-eric@anholt.net> In-Reply-To: <20170622175636.22723-2-eric@anholt.net> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.49] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-23_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5NEkrh7011645 Content-Length: 993 Lines: 34 On 06/22/2017 07:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt > --- > > This fixup would be squashed into patch 1 of your series. Hi Eric, and many thanks for the two patches, I will follow your suggestion for the v5 serie. By the way, do you have more comments on the "drm/stm: ltdc: Add panel-bridge support" patch? Many thanks :-) Philippe > drivers/gpu/drm/stm/ltdc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 7d7e889f09c3..d1d28348512b 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev) > bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI); > if (IS_ERR(bridge)) { > DRM_ERROR("Failed to create panel-bridge\n"); > - return PTR_ERR(bridge); > + ret = PTR_ERR(bridge); > + goto err; > } > ldev->is_panel_bridge = true; > } >