Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbdFWROG (ORCPT ); Fri, 23 Jun 2017 13:14:06 -0400 Received: from mail-ot0-f181.google.com ([74.125.82.181]:34914 "EHLO mail-ot0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754566AbdFWROD (ORCPT ); Fri, 23 Jun 2017 13:14:03 -0400 MIME-Version: 1.0 In-Reply-To: <1498208070-15584-1-git-send-email-raveendra.padasalagi@broadcom.com> References: <1498208070-15584-1-git-send-email-raveendra.padasalagi@broadcom.com> From: Raveendra Padasalagi Date: Fri, 23 Jun 2017 22:44:02 +0530 Message-ID: Subject: Re: [PATCH v1] crypto: brcm - software fallback for cryptlen zero To: Herbert Xu , "David S. Miller" , Rob Rice , Scott Branden , Ray Jui , Steve Lin , linux-crypto@vger.kernel.org Cc: bcm-kernel-feedback-list , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Raveendra Padasalagi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 43 Need to consider some more scenarios. So NAKing this patch. Will send out re-vised version. Regards, Raveendra On Fri, Jun 23, 2017 at 2:24 PM, Raveendra Padasalagi wrote: > Zero length payload requests are not handled in > Broadcom SPU2 engine, so this patch adds conditional > check to fallback to software implementation for AES-GCM > and AES-CCM algorithms. > > Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver") > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > Cc: stable@vger.kernel.org > --- > > Changes in v1: > - Added Cc tag in the Signed-off area to send the patch to stable kernel > > drivers/crypto/bcm/cipher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c > index cc0d5b9..6c80863 100644 > --- a/drivers/crypto/bcm/cipher.c > +++ b/drivers/crypto/bcm/cipher.c > @@ -2625,7 +2625,7 @@ static int aead_need_fallback(struct aead_request *req) > */ > if (((ctx->cipher.mode == CIPHER_MODE_GCM) || > (ctx->cipher.mode == CIPHER_MODE_CCM)) && > - (req->assoclen == 0)) { > + ((req->assoclen == 0) || (req->cryptlen == 0))) { > if ((rctx->is_encrypt && (req->cryptlen == 0)) || > (!rctx->is_encrypt && (req->cryptlen == ctx->digestsize))) { > flow_log("AES GCM/CCM needs fallback for 0 len req\n"); > -- > 1.9.1 >