DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 593167A16E
Date: Fri, 23 Jun 2017 11:15:54 -0600
From: Alex Williamson <alex.williamson@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Zhang, Tina" <tina.zhang@intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "Chen, Xiaoguang" <xiaoguang.chen@intel.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        "Wang, Zhenyu Z" <zhenyu.z.wang@intel.com>
Subject: Re: [Intel-gfx] [PATCH v9 5/7] vfio: Define vfio based dma-buf
 operations
Message-ID: <20170623111554.3a98f626@w520.home>
In-Reply-To: <1498202819.24807.3.camel@redhat.com>
References: <1497513611-2814-1-git-send-email-xiaoguang.chen@intel.com>
        <1497513611-2814-6-git-send-email-xiaoguang.chen@intel.com>
        <f19da207-a7f5-d3d3-4577-b071e7d75cf7@nvidia.com>
        <1497542438.29252.1.camel@redhat.com>
        <20170615143833.7526351b@w520.home>
        <24c4880b-24f5-ea07-834c-c77d3e895c78@nvidia.com>
        <1497854312.4207.4.camel@redhat.com>
        <20170619085530.1f5e46dc@w520.home>
        <237F54289DF84E4997F34151298ABEBC7C56EBE0@SHSMSX101.ccr.corp.intel.com>
        <1497956256.16795.7.camel@redhat.com>
        <20170620090004.44ac7fbc@w520.home>
        <237F54289DF84E4997F34151298ABEBC7C56F3DC@SHSMSX101.ccr.corp.intel.com>
        <20170620172204.09405cf4@w520.home>
        <237F54289DF84E4997F34151298ABEBC7C56F843@SHSMSX101.ccr.corp.intel.com>
        <1498043011.5802.5.camel@redhat.com>
        <20170621125938.1a92abda@w520.home>
        <1498120215.25651.5.camel@redhat.com>
        <20170622125458.01c953ab@w520.home>
        <1498202819.24807.3.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1560
Lines: 42

On Fri, 23 Jun 2017 09:26:59 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> > Is this only going to support accelerated driver output, not basic
> > VGA
> > modes for BIOS interaction?  
> 
> Right now there is no vgabios or uefi support for the vgpu.
> 
> But even with that in place there still is the problem that the display
> device initialization happens before the guest runs and therefore there
> isn't an plane yet ...
> 
> > > Right now the experimental intel patches throw errors in case no
> > > plane
> > > exists (yet).  Maybe we should have a "bool is_enabled" field in
> > > the
> > > plane_info struct, so drivers can use that to signal whenever the
> > > guest
> > > has programmed a valid video mode or not (likewise for the cursor,
> > > which doesn't exist with fbcon, only when running xorg).  With that
> > > in
> > > place using the QUERY_PLANE ioctl also for probing looks
> > > reasonable.  
> > 
> > Sure, or -ENOTTY for ioctl not implemented vs -EINVAL for no
> > available
> > plane, but then that might not help the user know how a plane would
> > be
> > available if it were available.  
> 
> So maybe a "enum plane_state" (instead of "bool is_enabled")?  So we
> can clearly disturgish ENABLED, DISABLED, NOT_SUPPORTED cases?

What's the difference between NOT_SUPPORTED and -ENOTTY on the ioctl?
Perhaps a bit in a flags field could specify EN/DIS-ABLED and leave
room for things we're forgetting.  Keep in mind that we need to use
explicit width fields for a uapi structure, so __u32 vs enum.  Thanks,

Alex