Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754800AbdFWRjv (ORCPT ); Fri, 23 Jun 2017 13:39:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34418 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbdFWRjt (ORCPT ); Fri, 23 Jun 2017 13:39:49 -0400 Date: Fri, 23 Jun 2017 13:39:47 -0400 (EDT) Message-Id: <20170623.133947.433422648753848462.davem@davemloft.net> To: julien@arista.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values From: David Miller In-Reply-To: <20170621175811.16940-1-julien@arista.com> References: <20170621175811.16940-1-julien@arista.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 23 Jun 2017 09:58:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 791 Lines: 23 From: Julien Gomes Date: Wed, 21 Jun 2017 10:58:10 -0700 > When sending a cache report on mroute_sk, mroute will emit a > "pending queue full" warning for every error value returned by > sock_queue_rcv_skb(). > This warning can be misleading, for example on the EPERM error value > that sk_filter() can return. > > Restricting this warning to only ENOMEM or ENOBUFS seems more > appropriate. > > Signed-off-by: Julien Gomes Incorrect, no other error codes are possible. We never attach a socket filter to these kernel internal sockets, therefore sk_filter() is not even applicable in this analysis. Therefore, -ENOBUFS and -ENOMEM are the only errors we can ever see returned from sock_queue_rcv_skb(). This goes for your second patch as well.