Date: Fri, 13 Jun 2003 00:15:17 -0700
From: Andrew Morton <akpm@digeo.com>
To: Roland McGrath <roland@redhat.com>
Cc: davidm@hpl.hp.com, torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: FIXMAP-related change to mm/memory.c
Message-Id: <20030613001517.5413e511.akpm@digeo.com>
In-Reply-To: <200306130656.h5D6uGc32359@magilla.sf.frob.com>
References: <16105.28970.526326.249287@napali.hpl.hp.com>
	<200306130656.h5D6uGc32359@magilla.sf.frob.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 946
Lines: 26

Roland McGrath <roland@redhat.com> wrote:
>
>  			static struct vm_area_struct fixmap_vma = {
>   				/* Catch users - if there are any valid
>   				   ones, we can make this be "&init_mm" or
>   				   something.  */
>   				.vm_mm = NULL,
>  -				.vm_start = FIXADDR_START,
>  -				.vm_end = FIXADDR_TOP,
>  +				.vm_start = FIXADDR_USER_START,
>  +				.vm_end = FIXADDR_USER_END,
>   				.vm_page_prot = PAGE_READONLY,
>   				.vm_flags = VM_READ | VM_EXEC,
>   			};

Note that the current version of this code does not compile for User Mode
Linux.  Its FIXADDR_TOP is not a constant.   It would be nice to fix that
this time around.

It appears that this patch will break x86_64, parisc and um.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/