Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754423AbdFWRzC (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 13:55:02 -0400
Received: from mail-pg0-f52.google.com ([74.125.83.52]:36326 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752878AbdFWRzB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 13:55:01 -0400
Date: Fri, 23 Jun 2017 10:54:56 -0700
From: Benson Leung <bleung@google.com>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>, olof@lixom.net,
        bleung@chromium.org, linux-kernel@vger.kernel.org,
        lee.jones@linaro.org, Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP
 events support over ACPI
Message-ID: <20170623175456.GA131781@decatoncale.mtv.corp.google.com>
References: <20170516161319.13257-1-enric.balletbo@collabora.com>
 <20170516161319.13257-10-enric.balletbo@collabora.com>
 <20170622193524.GA85041@decatoncale.mtv.corp.google.com>
 <10885390-8fc4-f21b-4f54-ef66572fc8d2@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl"
Content-Disposition: inline
In-Reply-To: <10885390-8fc4-f21b-4f54-ef66572fc8d2@collabora.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2119
Lines: 69


--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Thierry,

On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote:
> Hi Benson,
>=20
> On 22/06/2017 21:35, Benson Leung wrote:
>=20
> <snip>
>=20
> >>+	adev =3D ACPI_COMPANION(dev);
> >>+	if (adev) {
> >>+		status =3D acpi_install_notify_handler(adev->handle,
> >>+						     ACPI_ALL_NOTIFY,
> >
> >Is there a reason you're using ACPI_ALL_NOTIFY here instead of
> >ACPI_SYSTEM_NOTIFY that is done in the CHROMIUM version of this?
> >
> In the original patch
> (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY
> is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to
> acpi_remove_notify_handler. I changed it for remove_notify call to
> unsure all handler references were removed.
>=20

Oh, I see. Looks good. I'll go ahead and make the same change in the
chromeos-4.4 kernel too.

Signed-off-by: Benson Leung <bleung@chromium.org>

Applied.

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJZTVXwAAoJEB8J9XsKL+ZYRykP/2IcG4HJPABO05XeRU98WXT+
i9LVsjmiWeRnELLY6k4ClOFjcAzIGUo7C77WAoFYmh32dTkT3zFBafUFEBrA5elo
FWzDjxzobNZ0PGG4P7bWQvYXWRgxSvJezi9vDFVBryPGY3/Z7NRq+HhWGCXMQFp7
SjMadvrfrhpXgK75qACLcxo+6wpfP0AhB4mLOQqxKVBRMdyFsE1qEQEBOGuCHlft
n5L9qU4m0Sgue033mwDQNgddK7febGIjjMg0BnR00vE56oNB+tcQSCSHBwdBBiWq
feLBP+8kJ6hXdstaUTub9MBUx/61CcKa5pBO31SUZ4ZP/AShXvp6bx6yFeRCNDw/
fg2DB8e2QW77GoMzW31ThzWdxtaiEJwhkkHkSioQH5GYBnQ/azpAHFTO7BaT7HUO
YExkrzGS1UQ+iMCfbK/t5c56A2hsDuTTbw1xdQI6tIwBtIJiTylFEDK5+Jb3cFJX
w0GjKKf8QE8zJka24Wz1zl7pJl4BiM0KcWD0rEg+sY2gWwapKBYqK6JMg8lNfA0p
KX187RAQrlQencuhyqAo1TOMjSxpmsFRx/h5GcyYMKac/Rmaza1t7lzk7wDYdFRu
SxKT6kLLemR4s2A2gvGXUBYo/Qkiu+IN/OKRbkYWD2s/MW8EjY/b05K/8+uL2y6D
tleH0OedT6Lv6yg9bvWy
=e5Oy
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--