Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754799AbdFWSBf (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 14:01:35 -0400
Received: from esa8.dell-outbound.iphmx.com ([68.232.149.218]:8901 "EHLO
        esa8.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754572AbdFWSBb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 14:01:31 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.175.216.251
X-IronPort-AV: E=Sophos;i="5.39,379,1493701200"; 
   d="scan'208";a="1003575085"
To: <srinivas.pandruvada@linux.intel.com>, <rjw@rjwysocki.net>,
        <linux-acpi@vger.kernel.org>
CC: <linux-pm@vger.kernel.org>, <andriy.shevchenko@linux.intel.com>,
        <dvhart@infradead.org>, <linux-kernel@vger.kernel.org>,
        <mika.westerberg@linux.intel.com>, <tom@oneshoeco.com>,
        <jerome.debretagne@gmail.com>, <torvalds@linux-foundation.org>,
        <lv.zheng@intel.com>
Subject: RE: [PATCH v2] ACPI / sleep: EC-based wakeup from suspend-to-idle on
 recent systems
Thread-Topic: [PATCH v2] ACPI / sleep: EC-based wakeup from suspend-to-idle on
 recent systems
Thread-Index: AQHS7CPQm9r4QDuBo0iD5l6EAM3f3qIyh3+wgABpYgD//8vV4A==
Date: Fri, 23 Jun 2017 18:01:15 +0000
Message-ID: <745fa37f0ad6477e84131740828550f0@ausx13mpc120.AMER.DELL.COM>
References: <1979543.KIEJ8uyRaT@aspire.rjw.lan>
         <2026371.DVJN39QYJi@aspire.rjw.lan> <2368998.dmCsnrcXZy@aspire.rjw.lan>
         <2279758.LZ0rCGQtcH@aspire.rjw.lan>
         <3f1cbd8cd7e54576b17c788f4eae2205@ausx13mpc120.AMER.DELL.COM>
 <1498233988.7952.45.camel@linux.intel.com>
In-Reply-To: <1498233988.7952.45.camel@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.242.75]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5NI1hJm012425
Content-Length: 1557
Lines: 40

> -----Original Message-----
> From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com]
> Sent: Friday, June 23, 2017 11:06 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>; rjw@rjwysocki.net; linux-
> acpi@vger.kernel.org
> Cc: linux-pm@vger.kernel.org; andriy.shevchenko@linux.intel.com;
> dvhart@infradead.org; linux-kernel@vger.kernel.org;
> mika.westerberg@linux.intel.com; tom@oneshoeco.com;
> jerome.debretagne@gmail.com; torvalds@linux-foundation.org;
> lv.zheng@intel.com
> Subject: Re: [PATCH v2] ACPI / sleep: EC-based wakeup from suspend-to-idle on
> recent systems
> 
> On Fri, 2017-06-23 at 15:37 +0000, Mario.Limonciello@dell.com wrote:
> 
> [...]
> 
> > >
> > > +#define ACPI_LPS0_SCREEN_ON	4
> > > +#define ACPI_LPS0_ENTRY		5
> > > +#define ACPI_LPS0_EXIT		6
> > The spec you shared also defines device constraints (function 1). It
> > would be very
> > useful if these constraints  could be parsed and compared against the
> > actual power
> > states of devices on the system at least for debugging purposes.  I'm
> > not sure if you
> > already had a plan for that in a future series.
> >
> For debug purpose, I have worked on a patch to dump the constraint
> table in debugfs. But in the freeze path whether we meet the
> constraints or not will not make any difference, other than for just
> debugging.
> 
> Thanks,
> Srinivas

Right that was what I thought would be most interesting.  You can potentially
output to syslog as a last step going down what isn't in the right state to match
the constraint table.