Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754593AbdFWSP3 (ORCPT ); Fri, 23 Jun 2017 14:15:29 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35207 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014AbdFWSP2 (ORCPT ); Fri, 23 Jun 2017 14:15:28 -0400 Date: Fri, 23 Jun 2017 11:15:24 -0700 From: Brian Norris To: Colin Ian King Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , David Woodhouse , Boris Brezillon , Marek Vasut , Richard Weinberger , Cyrille Pitchen , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier Message-ID: <20170623181524.GB55942@google.com> References: <20170623090023.9482-1-colin.king@canonical.com> <20170623175124.GI14148@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 49 On Fri, Jun 23, 2017 at 07:03:11PM +0100, Colin Ian King wrote: > On 23/06/17 18:51, Brian Norris wrote: > > On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote: > >> On 2017-06-23 11:00, Colin King wrote: > >>> From: Colin Ian King > >>> > >>> Use %zx instead of %X for size_t variable offset, fixes build warning: > >>> > >>> warning: format '%X' expects argument of type 'unsigned int', but > >>> argument > >>> 2 has type 'size_t {aka long unsigned int}' [-Wformat=] > >>> > >>> Signed-off-by: Colin Ian King > >> > >> I sent similar patch few hours earlier: > >> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset > >> https://patchwork.ozlabs.org/patch/779789/ > >> > >> Brian: you may pick the one with nicer commit message, whichever one you > >> prefer :) > > > > I'll go with: > > (a) the earlier one and > > (b) the one that doesn't change 'X' to 'x' > > > > That means Rafał, you're our lucky winner today! Thanks for playing, > > Colin. > > FYI, I used %zx rather than %zX as couldn't find any instances of it in > the kernel and I wasn't 100% sure if it was supported or not. 'x' and 'X' are handled nearly identically in lib/vsprintf.c. Don't see why it wouldn't be. > linux-next: > > $ git grep "%zx" | wc -l > 161 > > $ git grep "%zX" | wc -l > 0 Yay, we're unique! Seriously though: I don't really care which one is used (though I guess I'm personally more used to lower-case hex). I just figured the less churn the better. Brian