Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754924AbdFWTjz (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 15:39:55 -0400
Received: from ms.lwn.net ([45.79.88.28]:41440 "EHLO ms.lwn.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754905AbdFWTjx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 15:39:53 -0400
Date: Fri, 23 Jun 2017 13:39:51 -0600
From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jim Davis <jim.epost@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion
Message-ID: <20170623133951.49bf28f8@lwn.net>
In-Reply-To: <20170619074906.250920c8@vento.lan>
References: <20170618234630.19964-1-corbet@lwn.net>
        <20170618234630.19964-3-corbet@lwn.net>
        <20170619073038.666a0eba@vento.lan>
        <20170619074906.250920c8@vento.lan>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1063
Lines: 31

On Mon, 19 Jun 2017 07:49:06 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:

> There's a catch, though: as sphinxsetup hmargin/vmargin was added
> only on Sphinx version 1.5.3, the enclosed patch won't adjust the
> margins for versions 1.5.0 to 1.5.2. While I didn't test, I bet it
> will just ignore the keys, showing some warning.

And people routinely accuse *me* of being overly optimistic...

> ! Package keyval Error: hmargin undefined.
> 
> See the keyval package documentation for explanation.
> Type  H <return>  for immediate help.
>  ...                                              
>                                                   
> l.19 \sphinxsetup{hmargin=0.5in, vmargin=0.5in}
>                                                
> ? 

So it kills the build on 1.5.2.

I've made a tweak to special-case early 1.5.x.  

> Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> Sighed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Sighed-off-by indeed, I agree.  It's a good thing there's a lot of beer in
the fridge...

jon