Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755168AbdFWUYb (ORCPT ); Fri, 23 Jun 2017 16:24:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45994 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755140AbdFWUYR (ORCPT ); Fri, 23 Jun 2017 16:24:17 -0400 Date: Fri, 23 Jun 2017 19:32:32 +0200 From: Greg Kroah-Hartman To: Simran Singhal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Sudip Mukherjee , Teddy Wang Subject: Re: [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t Message-ID: <20170623173232.GF19626@kroah.com> References: <20170619172120.GA28772@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170619172120.GA28772@singhal-Inspiron-5558> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 338 Lines: 11 On Mon, Jun 19, 2017 at 10:51:21PM +0530, Simran Singhal wrote: > This patch removes typedefs from enum _logical_chip_type_t and enum > _clock_type_t and rename them to logical_chip_type_t and clock_type_t > respectively. Why are you doing two different typedef fixups in a single patch? Please only do one at a time. thanks, greg k-h