Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755293AbdFWUZq (ORCPT ); Fri, 23 Jun 2017 16:25:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46568 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755277AbdFWUZp (ORCPT ); Fri, 23 Jun 2017 16:25:45 -0400 Date: Sat, 24 Jun 2017 00:16:31 +0800 From: Greg Kroah-Hartman To: simran singhal Cc: Oleg Drokin , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Andreas Dilger , lustre-devel@lists.lustre.org Subject: Re: [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool Message-ID: <20170623161631.GC20104@kroah.com> References: <20170620090637.GA15837@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620090637.GA15837@singhal-Inspiron-5558> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 488 Lines: 13 On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote: > This patch changes the type of variable done from int to boolean. As it > is been used as a boolean in the function sfw_test_rpc_done(). It also > makes the code more readable and bool data type also requires less > memory in comparison to int data type. Are you sure it takes less memory? What is the difference before and after your patch? Don't make claims without having a way to back them up :) thanks, greg k-h