Date: Fri, 23 Jun 2017 22:25:45 +0200 (CEST)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, rjui@broadcom.com,
        sbranden@broadcom.com, kernel@martin.sperl.org, rafal@milecki.pl,
        eric@anholt.net, rui.zhang@intel.com,
        bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
        edubezval@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Message-ID: <1667598657.325840.1498249545131@email.1und1.de>
In-Reply-To: <20170623194435.8094-1-christophe.jaillet@wanadoo.fr>
References: <20170623194435.8094-1-christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH v2] thermal: bcm2835: Fix error code in
 'bcm2835_thermal_probe'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Importance: Medium
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 450
Lines: 12


> Christophe JAILLET <christophe.jaillet@wanadoo.fr> hat am 23. Juni 2017 um 21:44 geschrieben:
> 
> 
> 'tz' is a valid pointer at this point, so calling PTR_ERR on it is
> pointless.
> This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above.
> So remove it. 'err' is already the error we want to report.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks, but Dan Carpenter already send a fix for this.