Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754527AbdFWV0N (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Jun 2017 17:26:13 -0400
Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:34621
        "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1753306AbdFWV0L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Jun 2017 17:26:11 -0400
Date: Fri, 23 Jun 2017 18:26:02 -0300
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jim Davis <jim.epost@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/5] Docs: Remove redundant geometry package inclusion
Message-ID: <20170623182602.5b2dfc0a@vento.lan>
In-Reply-To: <20170623133951.49bf28f8@lwn.net>
References: <20170618234630.19964-1-corbet@lwn.net>
        <20170618234630.19964-3-corbet@lwn.net>
        <20170619073038.666a0eba@vento.lan>
        <20170619074906.250920c8@vento.lan>
        <20170623133951.49bf28f8@lwn.net>
Organization: Samsung
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1828
Lines: 56

Em Fri, 23 Jun 2017 13:39:51 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:

> On Mon, 19 Jun 2017 07:49:06 -0300
> Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> 
> > There's a catch, though: as sphinxsetup hmargin/vmargin was added
> > only on Sphinx version 1.5.3, the enclosed patch won't adjust the
> > margins for versions 1.5.0 to 1.5.2. While I didn't test, I bet it
> > will just ignore the keys, showing some warning.  
> 
> And people routinely accuse *me* of being overly optimistic...

:-)

> > ! Package keyval Error: hmargin undefined.
> > 
> > See the keyval package documentation for explanation.
> > Type  H <return>  for immediate help.
> >  ...                                              
> >                                                   
> > l.19 \sphinxsetup{hmargin=0.5in, vmargin=0.5in}
> >                                                
> > ?   
> 
> So it kills the build on 1.5.2.

Murphy's law applied to coding: Anything untested that can go wrong 
will go wrong :-)

Sorry for that.

> 
> I've made a tweak to special-case early 1.5.x.  
> 
> > Fixes: 85c21e5c3ee74fb75d690c57f7066bae7e2dca55
> > Sighed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>  
> 
> Sighed-off-by indeed, I agree.  It's a good thing there's a lot of beer in
> the fridge...

Heh. Yeah, your changes look OK to me.

Btw, I tried for some time to fix pdf build with Sphinx 1.6 without
much luck. The new table macros version 1.6 adds makes almost
impossible to use adjustbox before a table, because it calls
vskip on them. The solution seems to either redefine those macros
or to override tabulary for it to always call adjustbox.

Unfortunately, I'm not fluent on LaTeX macros, so it takes me a
lot of time to work on it.

I'll try to look on it later, after the merge window.

Regards,
Mauro