Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754615AbdFWVt3 (ORCPT ); Fri, 23 Jun 2017 17:49:29 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34775 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbdFWVt0 (ORCPT ); Fri, 23 Jun 2017 17:49:26 -0400 Date: Fri, 23 Jun 2017 16:49:23 -0500 From: Rob Herring To: Varadarajan Narayanan Cc: broonie@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Abhishek Sahu Subject: Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma Message-ID: <20170623214923.ratchkoay73ytlv3@rob-hp-laptop> References: <1497949857-1852-1-git-send-email-varada@codeaurora.org> <1497949857-1852-16-git-send-email-varada@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497949857-1852-16-git-send-email-varada@codeaurora.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1873 Lines: 38 On Tue, Jun 20, 2017 at 02:40:57PM +0530, Varadarajan Narayanan wrote: > Currently the QUP Version v1 does not work with DMA so added > the support for the same. > > 1. It uses ADM DMA which requires TX and RX CRCI > 2. DMA channel initialization need to be done after setting > block size for having valid values in maxburst > 3. QUP mode should be DMOV instead of BAM. > > Signed-off-by: Abhishek Sahu > Signed-off-by: Varadarajan Narayanan > --- > .../devicetree/bindings/spi/qcom,spi-qup.txt | 6 ++++ > drivers/spi/spi-qup.c | 35 +++++++++++++++++----- > 2 files changed, 34 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > index 5c09077..e754181 100644 > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > @@ -38,6 +38,12 @@ Optional properties: > - dma-names: Names for the dma channels, if present. There must be at > least one channel named "tx" for transmit and named "rx" for > receive. > +- qcom,tx-crci: Identificator for Client Rate Control Interface (CRCI) to be Identificator is not a word. This sounds like something that should be a cell in the dmas property. > + used with TX DMA channel. Required when using DMA for > + transmission with QUP Version 1 i.e qcom,spi-qup-v1.1.1. > +- qcom,rx-crci: Identificator for Client Rate Control Interface (CRCI) to be > + used with RX DMA channel. Required when using DMA for > + receiving with QUP Version 1 i.e qcom,spi-qup-v1.1.1. > > SPI slave nodes must be children of the SPI master node and can contain > properties described in Documentation/devicetree/bindings/spi/spi-bus.txt