From: Palmer Dabbelt <palmer@dabbelt.com>
To: rth@twiddle.net
To: ink@jurassic.park.msu.ru
To: mattst88@gmail.com
To: vgupta@synopsys.com
To: linux@armlinux.org.uk
To: catalin.marinas@arm.com
To: will.deacon@arm.com
To: geert@linux-m68k.org
To: ralf@linux-mips.org
To: ysato@users.sourceforge.jp
To: dalias@libc.org
To: davem@davemloft.net
To: cmetcalf@mellanox.com
To: gxt@mprc.pku.edu.cn
To: bhelgaas@google.com
To: viro@zeniv.linux.org.uk
To: akpm@linux-foundation.org
To: linux-alpha@vger.kernel.org
To: linux-kernel@vger.kernel.org
To: linux-snps-arc@lists.infradead.org
To: linux-arm-kernel@lists.infradead.org
To: linux-m68k@vger.kernel.org
To: linux-mips@linux-mips.org
To: linux-sh@vger.kernel.org
To: sparclinux@vger.kernel.org
To: linux-pci@vger.kernel.org
To: hch@infradead.org
Subject: Re: [PATCH] pci:  Add and use PCI_GENERIC_SETUP Kconfig entry
Date: Fri, 23 Jun 2017 15:08:56 -0700
Message-Id: <20170623220857.28774-1-palmer@dabbelt.com>
In-Reply-To: <20170623220104.GE31455@jhogan-linux.le.imgtec.org>
References: <20170623220104.GE31455@jhogan-linux.le.imgtec.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1552
Lines: 46

On Fri, 23 Jun 2017 15:01:04 PDT (-0700), james.hogan@imgtec.com wrote:
> On Fri, Jun 23, 2017 at 02:45:38PM -0700, Palmer Dabbelt wrote:
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 4c1a35f15838..86872246951c 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -96,6 +96,7 @@ config ARM
>>      select PERF_USE_VMALLOC
>>      select RTC_LIB
>>      select SYS_SUPPORTS_APM_EMULATION
>> +    select PCI_GENERIC_SETUP
>>      # Above selects are sorted alphabetically; please add new ones
>>      # according to that.  Thanks.
>
> This comment seems to suggest PCI_GENERIC_SETUP should be added a few
> lines up to preserve the alphabetical sorting.
>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index b2024db225a9..6c684d8c8816 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -115,6 +115,7 @@ config ARM64
>>      select SPARSE_IRQ
>>      select SYSCTL_EXCEPTION_TRACE
>>      select THREAD_INFO_IN_TASK
>> +    select PCI_GENERIC_SETUP
>
> Here too.
>
>> diff --git a/arch/tile/Kconfig b/arch/tile/Kconfig
>> index 4583c0320059..6679af85a882 100644
>> --- a/arch/tile/Kconfig
>> +++ b/arch/tile/Kconfig
>> @@ -33,6 +33,7 @@ config TILE
>>      select USER_STACKTRACE_SUPPORT
>>      select USE_PMC if PERF_EVENTS
>>      select VIRT_TO_BUS
>> +    select PCI_GENERIC_SETUP
>
> and here
>
> Otherwise
> Reviewed-by: James Hogan <james.hogan@imgtec.com>

Whoops -- I guess I was just on autopilot after seeing the first one not be
alphabetized.  A fixed patch is in a threaded message.