Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbdFXHzo (ORCPT ); Sat, 24 Jun 2017 03:55:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47364 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdFXHzn (ORCPT ); Sat, 24 Jun 2017 03:55:43 -0400 Date: Sat, 24 Jun 2017 09:55:36 +0200 From: Greg KH To: Arvind Yadav Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: core: sysfs: constify attribute_group Message-ID: <20170624075536.GA9346@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 906 Lines: 25 On Fri, Jun 23, 2017 at 11:28:10AM +0530, Arvind Yadav wrote: > File size before: > text data bss dec hex filename > 6798 2848 4 9650 25b2 drivers/usb/core/sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 7230 2400 4 9634 25a2 drivers/usb/core/sysfs.o > > Signed-off-by: Arvind Yadav You have sent a lot of these types of patches out, and really, this is a horrible changelog entry. You are assuming that I know what this is, and why it is a good thing. Now I might, but maybe not... Please actually explain why you are making this change. Why it is needed. And big hint, it's not only about the output of the file size... Please fix this up for all of the patches you have sent me in this format, as I'm deleting them all from my queue right now. thanks, greg k-h