Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751362AbdFXH4L (ORCPT ); Sat, 24 Jun 2017 03:56:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47380 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbdFXH4K (ORCPT ); Sat, 24 Jun 2017 03:56:10 -0400 Date: Sat, 24 Jun 2017 09:56:03 +0200 From: Greg KH To: Arvind Yadav Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: host: ohci-pxa27x: Handle return value of clk_prepare_enable Message-ID: <20170624075603.GB9346@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 354 Lines: 14 On Thu, Jun 15, 2017 at 10:20:18AM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > > Changes in v2: > Remove useless initialization of retval. > --- changes go below the --- line. Please fix and resend. thanks, greg k-h