Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbdFXPAa (ORCPT ); Sat, 24 Jun 2017 11:00:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:51430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdFXPA3 (ORCPT ); Sat, 24 Jun 2017 11:00:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 012C022B5D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [PATCH] f2fs: avoid redundant f2fs_flush after remount To: Yunlong Song , jaegeuk@kernel.org, yuchao0@huawei.com, sylinux@163.com Cc: miaoxie@huawei.com, bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1498291039-142563-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <53263f00-2bed-b547-a2b2-ceb9f9aa94ec@kernel.org> Date: Sat, 24 Jun 2017 22:59:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1498291039-142563-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 28 On 2017/6/24 15:57, Yunlong Song wrote: > create_flush_cmd_control will create redundant issue_flush_thread after each > remount with flush_merge option. > > Signed-off-by: Yunlong Song Reviewed-by: Chao Yu Thanks, > --- > fs/f2fs/segment.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index a6d7738..57f9edc 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi) > > if (SM_I(sbi)->fcc_info) { > fcc = SM_I(sbi)->fcc_info; > + if (fcc->f2fs_issue_flush) > + return err; > goto init_thread; > } > >