Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbdFYVn5 (ORCPT ); Sun, 25 Jun 2017 17:43:57 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:32967 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbdFYVnz (ORCPT ); Sun, 25 Jun 2017 17:43:55 -0400 Date: Sun, 25 Jun 2017 14:43:52 -0700 From: Bjorn Andersson To: Henri Roosen Cc: linux-remoteproc@vger.kernel.org, Ohad Ben-Cohen , open list Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Message-ID: <20170625214352.GI26155@builder> References: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496403382-32374-1-git-send-email-henri.roosen@ginzinger.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 30 On Fri 02 Jun 04:36 PDT 2017, Henri Roosen wrote: > Trivial cleanup: the .ops pointer is assigned twice. This patch removes the > first assignment. > > Signed-off-by: Henri Roosen Applied, thanks > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 3c582f2..35b8379 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp, > /* Link the channel to our vrp */ > vch->vrp = vrp; > > - /* Assign callbacks for rpmsg_channel */ > - vch->rpdev.ops = &virtio_rpmsg_ops; > - > /* Assign public information to the rpmsg_device */ > rpdev = &vch->rpdev; > rpdev->src = chinfo->src; > -- > 2.1.4 >