Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751390AbdFZIzg (ORCPT ); Mon, 26 Jun 2017 04:55:36 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:29619 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdFZIz1 (ORCPT ); Mon, 26 Jun 2017 04:55:27 -0400 Subject: Re: [PATCH 6/7] drm/tilcdc: clean up ifdef hacks around iowrite64 To: Logan Gunthorpe , , , , , , , CC: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Tomi Valkeinen , David Airlie References: <20170622164817.25515-1-logang@deltatee.com> <20170622164817.25515-7-logang@deltatee.com> From: Jyri Sarha Message-ID: <504da99a-838c-48ec-c5b2-6b611d587a10@ti.com> Date: Mon, 26 Jun 2017 11:55:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170622164817.25515-7-logang@deltatee.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 36 On 06/22/17 19:48, Logan Gunthorpe wrote: > Now that we can expect iowrite64 to always exist the hack is no longer > necessary so we just call iowrite64 directly. > > Signed-off-by: Logan Gunthorpe > Cc: Jyri Sarha > Cc: Tomi Valkeinen > Cc: David Airlie Acked-by: Jyri Sarha And thanks! > --- > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > index e9ce725698a9..0b901405f30a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h > @@ -133,13 +133,7 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data) > struct tilcdc_drm_private *priv = dev->dev_private; > void __iomem *addr = priv->mmio + reg; > > -#ifdef iowrite64 > iowrite64(data, addr); > -#else > - __iowmb(); > - /* This compiles to strd (=64-bit write) on ARM7 */ > - *(u64 __force *)addr = __cpu_to_le64(data); > -#endif > } > > static inline u32 tilcdc_read(struct drm_device *dev, u32 reg) >