Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdFZJTs (ORCPT ); Mon, 26 Jun 2017 05:19:48 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:34974 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbdFZJT2 (ORCPT ); Mon, 26 Jun 2017 05:19:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1498455936-2108-1-git-send-email-abdallah.meziti.pro@gmail.com> From: Geert Uytterhoeven Date: Mon, 26 Jun 2017 11:19:27 +0200 X-Google-Sender-Auth: qPmOOR02qFlIEagR5RkoswEHqXM Message-ID: Subject: Re: [PATCH] staging: sm750fb: always take the lock To: Frans Klaver Cc: AbdAllah-MEZITI , Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , Linux Fbdev development list , driverdevel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 33 On Mon, Jun 26, 2017 at 11:16 AM, Frans Klaver wrote: > On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven > wrote: >> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI >> wrote: >>> This patch >>> - will always take the lock >> >> Why? >> >> "The current code only takes the lock if multiple instances are in use. >> This is error-prone, and confuses static analyzers. >> As taking the lock in case of a single instance is harmful and cheap, >> change the code to always take the lock." > > I would argue that it's not harmful, lest people get confused about Sorry, I meant "harmless". I should start caring as much for commit messages I write for other people as for those I write for myself ;-) > it. And I agree that this explanation is much more useful than just > mentioning the warnings that you saw. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds