Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751592AbdFZJo5 (ORCPT ); Mon, 26 Jun 2017 05:44:57 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:33069 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbdFZJos (ORCPT ); Mon, 26 Jun 2017 05:44:48 -0400 Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: free 'dummy_sc' in sc_fop_release() in case of memory leak To: piaojun , mfasheh@versity.com, jlbec@evilplan.org Cc: linux-kernel@vger.kernel.org, "ocfs2-devel@oss.oracle.com" , "akpm@linux-foundation.org" References: <594FB0A4.2050105@huawei.com> From: Joseph Qi Message-ID: <7d3b370d-8d93-8419-6c09-284259d85287@gmail.com> Date: Mon, 26 Jun 2017 17:44:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <594FB0A4.2050105@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 29 On 17/6/25 20:46, piaojun wrote: > 'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end > of sc_fop_release(). > > Signed-off-by: Jun Piao Looks good. Reviewed-by: Joseph Qi Thanks, Joseph > --- > fs/ocfs2/cluster/netdebug.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c > index 564c504..74a21f6 100644 > --- a/fs/ocfs2/cluster/netdebug.c > +++ b/fs/ocfs2/cluster/netdebug.c > @@ -426,6 +426,7 @@ static int sc_fop_release(struct inode *inode, struct file *file) > struct o2net_sock_container *dummy_sc = sd->dbg_sock; > > o2net_debug_del_sc(dummy_sc); > + kfree(dummy_sc); > return seq_release_private(inode, file); > } >