Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbdFZLG2 (ORCPT ); Mon, 26 Jun 2017 07:06:28 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:55439 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdFZLGX (ORCPT ); Mon, 26 Jun 2017 07:06:23 -0400 Reply-To: kieran.bingham@ideasonboard.com Subject: Re: [PATCH v5 1/2] media: i2c: adv748x: add adv748x driver To: Rob Herring , Kieran Bingham Cc: laurent.pinchart@ideasonboard.com, niklas.soderlund@ragnatech.se, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Mark Rutland , Kieran Bingham , Greg Kroah-Hartman , "David S. Miller" , "Martin K. Petersen" , Hans Verkuil , Sakari Ailus , Pavel Machek , Steve Longerbeam , Robert Jarzmik , Ramiro Oliveira , Arnd Bergmann , Todor Tomov , "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20170622213401.jdktgcx5tbsxhh5d@rob-hp-laptop> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Mon, 26 Jun 2017 12:06:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170622213401.jdktgcx5tbsxhh5d@rob-hp-laptop> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 52 Thanks Rob, Comments addressed, and a new version 6 to be posted soon. On 22/06/17 22:34, Rob Herring wrote: > On Wed, Jun 14, 2017 at 08:58:12PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled with 4 subdevices to allow simultaneous streaming >> from the AFE (Analog front end) and HDMI inputs though two CSI TX >> entities. >> >> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked >> to the TXB CSI bus. >> >> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP, >> and an earlier rework by Niklas Söderlund. >> >> Signed-off-by: Kieran Bingham >> >> --- ... >> + >> +The digital output port nodes must contain at least one endpoint. >> + >> +Ports are optional if they are not connected to anything at the hardware level, >> +but the driver may not provide any support for ports which are not described. > > What the driver does is not relevant to the binding. Of course. (Fixed) > >> + >> +Example: >> + >> + video_receiver@70 { > > video-receiver@70 Aha, I didn't realise the distinction between using '-' in node names and properties vs '_' in labels. Hopefully updated in my mind map. And I'll try to get this one right in the future. :) -- Regards Kieran