Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920AbdFZMsF (ORCPT ); Mon, 26 Jun 2017 08:48:05 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:34299 "EHLO mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdFZMr7 (ORCPT ); Mon, 26 Jun 2017 08:47:59 -0400 MIME-Version: 1.0 In-Reply-To: <20170626144540.9af644d8ab6140f7f4718d06@bidouilliste.com> References: <20170626124249.9475-1-net147@gmail.com> <20170626144540.9af644d8ab6140f7f4718d06@bidouilliste.com> From: Jonathan Liu Date: Mon, 26 Jun 2017 22:47:57 +1000 Message-ID: Subject: Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins To: Emmanuel Vadot Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Rutland , Russell King , devicetree , linux-sunxi , linux-kernel , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2101 Lines: 58 Hi Emmanuel, On 26 June 2017 at 22:45, Emmanuel Vadot wrote: > On Mon, 26 Jun 2017 22:42:49 +1000 > Jonathan Liu wrote: > >> The LCD0 controller on the A20 can do RGB output up to 8 bits per >> channel. Add the pins for RGB888 output. >> >> Signed-off-by: Jonathan Liu >> --- >> arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi >> index 96bee776e145..09a0e89bed11 100644 >> --- a/arch/arm/boot/dts/sun7i-a20.dtsi >> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >> @@ -1183,6 +1183,17 @@ >> function = "ir1"; >> }; >> >> + lcd0_rgb888_pins: lcd0_rgb888@0 { >> + allwinner,pins = "PD0", "PD1", "PD2", "PD3", >> + "PD4", "PD5", "PD6", "PD7", >> + "PD8", "PD9", "PD10", "PD11", >> + "PD12", "PD13", "PD14", "PD15", >> + "PD16", "PD17", "PD18", "PD19", >> + "PD20", "PD21", "PD22", "PD23", >> + "PD24", "PD25", "PD26", "PD27"; >> + allwinner,function = "lcd0"; >> + }; >> + > > We switch to standard pinctrl bindings so you need to use 'pins' and > 'function' (i.e. without the 'allwinner,' prefix). > Thanks, I will change it for V2. >> mmc0_pins_a: mmc0@0 { >> pins = "PF0", "PF1", "PF2", >> "PF3", "PF4", "PF5"; >> -- >> 2.13.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > -- > Emmanuel Vadot Regards, Jonathan