DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E338F8046F
Date: Mon, 26 Jun 2017 15:37:12 +0200
From: Jessica Yu <jeyu@redhat.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and
 del_usage_link functions
Message-ID: <20170626133711.gsu4jgmj6rsm737x@redbean>
References: <20170606121740.350-1-clabbe.montjoie@gmail.com>
 <20170606121740.350-2-clabbe.montjoie@gmail.com>
 <20170619162622.7hbxm6k53f43nooh@redbean>
 <20170620064539.GA12930@Red>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20170620064539.GA12930@Red>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 890
Lines: 30

+++ Corentin Labbe [20/06/17 08:45 +0200]:
>On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
>> +++ Corentin Labbe [06/06/17 14:17 +0200]:
>> >This patch just swap del_usage_link() before add_usage_link().
>> >
>> >Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>>
>> Could you combine this with the 2nd patch? By itself this patch
>> doesn't tell us much. Additionally, could you explain in the changelog
>> (of the 2nd patch) why they needed to be swapped (i.e., so
>> del_usage_links() can be called from add_usage_links()).
>>
>> Thanks!
>>
>> Jessica
>>
>
>I think that its against the rule of atomic/simple patch.
>Perhaps, the first patch miss some "why I do it"
>
>Anyway I will send a new version as you requested

Hi Corentin,

I've folded the first patch with the second and applied them to
modules-next, no need to resend the patchset :)

Thanks!

Jessica